Skip to content

test(e2e): extend Azl3 and ACL GPU e2e scenarios to cover NCA10#8716

Open
miz060 wants to merge 1 commit into
mainfrom
mitchzhu/nca10_azl_acl_e2e
Open

test(e2e): extend Azl3 and ACL GPU e2e scenarios to cover NCA10#8716
miz060 wants to merge 1 commit into
mainfrom
mitchzhu/nca10_azl_acl_e2e

Conversation

@miz060

@miz060 miz060 commented Jun 15, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Extend Azl3 and ACL GPU e2e scenarios to cover NCA10 since it's now supported by both OSSKU

AB E2E run: https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=168178190&view=results
(updated A10 GPU test passed)

Which issue(s) this PR fixes:

Fixes #

Copilot AI review requested due to automatic review settings June 15, 2026 22:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the GPU e2e coverage in the e2e Go module to include the NCA10 (A10) VM SKU across Azure Linux V3 and ACL scenarios, improving validation for newly supported GPU offerings.

Changes:

  • Expand Test_ACL_GPUA10 to run the scenario for both Standard_NV6ads_A10_v5 and Standard_NC16ads_A10_v4.
  • Expand Test_AzureLinuxV3_GPUA10 to run the scenario for both A10 SKUs and include the VM size in the scenario description.

Comment thread e2e/scenario_test.go
Comment thread e2e/scenario_test.go

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The AzureLinuxV3 A10 scenario now disables the auto-generated scriptless coverage (SkipScriptlessNBC: true) without explanation, which reduces E2E coverage and should be justified or adjusted.

Copilot's findings
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

Comment thread e2e/scenario_test.go Outdated
…s_A10_v5

Add AB E2E for Azl3 and ACL with NCA10 GPU

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
@miz060 miz060 force-pushed the mitchzhu/nca10_azl_acl_e2e branch from 230c55b to 0ceb017 Compare June 16, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants