Skip to content

Pin transitive jws to 3.2.3 in pnpm workspace#2010

Draft
mikeharder with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-hmac-signature-verification
Draft

Pin transitive jws to 3.2.3 in pnpm workspace#2010
mikeharder with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-hmac-signature-verification

Conversation

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This updates the repo’s transitive npm resolution to remove the vulnerable jws@3.2.2 path flagged by Dependabot (GHSA-869p-cjfg-cm3x / CVE-2025-65945). The affected package was not directly declared in this repo; it was pulled in through TypeSpec dev tooling.

  • Dependency resolution

    • Moved pnpm overrides into pnpm-workspace.yaml, where pnpm v10 actually applies them.
    • Added an explicit override for jws: 3.2.3.
    • Refreshed pnpm-lock.yaml so jsonwebtoken@9.0.2 now resolves the patched jws version.
  • Scope of impact

    • The vulnerable path is transitive only:
      @typespec/spector -> @azure/identity -> @azure/msal-node -> jsonwebtoken -> jws
    • No direct source usage of jws.createVerify(), jws.verify(), or jsonwebtoken was found in the repository.
  • Reachability Assessment

    • Status: Not reachable
    • Why: The advisory requires use of jws.createVerify() for HMAC verification with user-influenced header/payload-based secret lookup. Repository search found no call sites for the affected APIs or library in source files.
    • Confidence: High
    • Implication: This change primarily removes a vulnerable transitive resolution for scanner compliance rather than remediating an actively exercised code path.
  • Example of the effective change

    overrides:
      jws: 3.2.3
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>auth0/node-jws Improperly Verifies HMAC Signature</alert_title>
<alert_description>### Overview
An improper signature verification vulnerability exists when using auth0/node-jws with the HS256 algorithm under specific conditions.

Am I Affected?

You are affected by this vulnerability if you meet all of the following preconditions:

  1. Application uses the auth0/node-jws implementation of JSON Web Signatures, versions <=3.2.2 || 4.0.0
  2. Application uses the jws.createVerify() function for HMAC algorithms
  3. Application uses user-provided data from the JSON Web Signature Protected Header or Payload in the HMAC secret lookup routines

You are NOT affected by this vulnerability if you meet any of the following preconditions:

  1. Application uses the jws.verify() interface (note: auth0/node-jsonwebtoken users fall into this category and are therefore NOT affected by this vulnerability)
  2. Application uses only asymmetric algorithms (e.g. RS256)
  3. Application doesn’t use user-provided data from the JSON Web Signature Protected Header or Payload in the HMAC secret lookup routines

Fix

Upgrade auth0/node-jws version to version 3.2.3 or 4.0.1

Acknowledgement

Okta would like to thank Félix Charette for discovering this vulnerability.</alert_description>

high
GHSA-869p-cjfg-cm3x, CVE-2025-65945
jws
npm
<vulnerable_versions>3.2.2</vulnerable_versions>
<patched_version>3.2.3</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>

https://github.com/auth0/node-jws/security/advisories/GHSA-869p-cjfg-cm3x https://github.com/auth0/node-jws/commit/34c45b2c04434f925b638de6a061de9339c0ea2e https://github.com/auth0/node-jws/commit/4f6e73f24df42f07d632dec6431ade8eda8d11a6 https://github.com/auth0/node-jws/releases/tag/v3.2.3 https://github.com/auth0/node-jws/releases/tag/v4.0.1 https://nvd.nist.gov/vuln/detail/CVE-2025-65945 https://github.com/advisories/GHSA-869p-cjfg-cm3x

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting ...

Copilot AI changed the title [WIP] Fix improper HMAC signature verification in node-jws Pin transitive jws to 3.2.3 in pnpm workspace Jun 24, 2026
Copilot AI requested a review from mikeharder June 24, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants