{CI} Fix update_index wheel filename + bump pinned azdev to latest#10039
Open
aryasadeghi1 wants to merge 2 commits into
Open
{CI} Fix update_index wheel filename + bump pinned azdev to latest#10039aryasadeghi1 wants to merge 2 commits into
aryasadeghi1 wants to merge 2 commits into
Conversation
get_ext_metadata reads wheel metadata via pkginfo now, which needs a .whl-named file. update_index was saving the download as just the extension name (e.g. ssh), so pkginfo rejected it with 'Not a known wheel archive format' and the publish index update failed. Use the filename from the URL, like the rest of the script already does for the index entry.
The previous pin predated azdev's extension update-index wheel-filename fix. Point both jobs at the current dev commit so CI runs azdev with all the merged decoupling fixes, until 0.2.11b1 is published to PyPI.
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @aryasadeghi1, |
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
jsntcy and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the CI index update path after the switch to pkginfo-based wheel metadata by ensuring the downloaded wheel is saved with its real .whl filename, and it updates the pinned azdev source commit so CI consumes the corresponding upstream fix.
Changes:
- Save the downloaded wheel using the filename from the wheel URL (so
pkginfocan read it as a wheel archive). - Bump the pinned
azure-cli-dev-tools(azdev) git commit in both ADO pipeline entrypoints.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/ci/update_index.py |
Downloads the wheel using its actual .whl filename to support pkginfo-based metadata reads. |
azure-pipelines.yml |
Updates the pinned azdev git commit used by the IndexVerify job. |
.azure-pipelines/templates/azdev_setup.yml |
Updates the pinned azdev git commit used by the shared azdev setup template. |
Collaborator
|
CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #9922 so the decoupled (pkginfo) azdev path works end to end:
scripts/ci/update_index.py saved the downloaded wheel as just the extension name, but pkginfo.Wheel needs a .whl-named file, so the publish index update failed with "Not a known wheel archive format". Use the real filename from the URL (as the entry already does).
Bump the pinned azdev (azdev_setup.yml + azure-pipelines.yml) 49390f3 -> 644d296, the current dev commit that includes azdev's matching
extension update-indexfix. Stays pinned until azdev 0.2.11 is published to PyPI.