Skip to content

fix: 시트 동아리 등록 상세 소개 빈 값 저장#665

Merged
JanooGwan merged 1 commit into
developfrom
fix/sheet-import-empty-introduce
Jun 5, 2026
Merged

fix: 시트 동아리 등록 상세 소개 빈 값 저장#665
JanooGwan merged 1 commit into
developfrom
fix/sheet-import-empty-introduce

Conversation

@JanooGwan
Copy link
Copy Markdown
Contributor

@JanooGwan JanooGwan commented Jun 5, 2026

🔍 개요

  • 동아리 엑셀 양식에는 상세 소개 컬럼이 없으므로, Google Sheet import preview 및 confirm에서 상세 소개를 빈 값으로 처리하도록 변경했습니다.

🚀 주요 변경 내용

  • 시트 import preview 응답의 introduce를 한 줄 소개 복사값이 아닌 빈 문자열로 반환합니다.
  • 시트 import confirm 시 WebClub.introduce에 빈 문자열을 저장할 수 있도록 DTO 검증과 저장 로직을 조정했습니다.
  • 관련 서비스/컨트롤러 단위 테스트를 갱신했습니다.

💬 참고 사항

  • WebClub.introduce 컬럼은 nullable=false이므로 null이 아닌 빈 문자열로 저장합니다.
  • description은 기존처럼 한 줄 소개로 유지됩니다.

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Warning

Review limit reached

@JanooGwan, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 17 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c789d46a-bd41-4fe2-b502-d358e084b6ca

📥 Commits

Reviewing files that changed from the base of the PR and between 0167150 and a00a403.

📒 Files selected for processing (4)
  • src/main/java/gg/agit/konect/admin/website/dto/AdminWebsiteClubSheetImportConfirmRequest.java
  • src/main/java/gg/agit/konect/admin/website/service/AdminWebsiteClubSheetImportService.java
  • src/test/java/gg/agit/konect/unit/admin/website/controller/AdminWebsiteClubSheetImportControllerTest.java
  • src/test/java/gg/agit/konect/unit/admin/website/service/AdminWebsiteClubSheetImportServiceTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sheet-import-empty-introduce

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JanooGwan JanooGwan added the 버그 정상적으로 동작하지 않는 문제 상황 관련 이슈입니다. label Jun 5, 2026
@JanooGwan JanooGwan self-assigned this Jun 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🧪 JaCoCo Coverage Report (Changed Files)

Summary

  • Overall Coverage: 79.0% ✅
  • Covered Lines: 124 / 157
  • Changed Files: 2

Coverage by File

Class Coverage Lines Status
AdminWebsiteClubSheetImportService
gg.agit.konect.admin.website.service
79.0% 124/157

📊 View Workflow Run

@JanooGwan JanooGwan merged commit c7c6c75 into develop Jun 5, 2026
5 checks passed
@JanooGwan JanooGwan deleted the fix/sheet-import-empty-introduce branch June 5, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 정상적으로 동작하지 않는 문제 상황 관련 이슈입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant