fix(dd4hepplugins): sync bundled dRICH radiator XML with epic >= 26.06#421
Merged
Conversation
epic 26.06 segmented the dRICH aerogel into trapezoidal tiles held by carbon-fiber support frames, and its DRICH plugin now requires a <coronas> element inside <radiator>. The bundled single-sector compact predates this, so geometry construction fails against current epic with Handle_t::child: Element [radiator] has no child of type 'coronas' breaking benchmark_drich.py (and validate_drich.py once it points at this geometry). Port the <coronas> block and the DRICH_corona_thickness constant from epic's compact/pid/drich.xml. Older DRICH plugins (epic <= 26.05) never query the element and DD4hep ignores unknown children, so the file remains usable with older stacks. Verified with benchmark_drich.py --mode cpu against an epic main build: construction succeeds and a full event completes.
plexoos
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
epic 26.06 segmented the dRICH aerogel into trapezoidal tiles held by carbon fiber support frames, and its DRICH plugin now requires a element inside . The bundled single-sector compact predates this, so geometry construction fails against current epic with
Handle_t::child: Element [radiator] has no child of type 'coronas'
breaking benchmark_drich.py (and validate_drich.py once it points at this geometry). Port the block and the DRICH_corona_thickness constant from epic's compact/pid/drich.xml. Older DRICH plugins (epic <= 26.05) never query the element and DD4hep ignores unknown children, so the file remains usable with older stacks.
Verified with benchmark_drich.py --mode cpu against an epic main build: construction succeeds and a full event completes.