Feature/inbound accept decline#15
Open
smoghe-bw wants to merge 4 commits into
Open
Conversation
Reworks the inbound-call flow onto the new gateway/SDK paradigm: the gateway rides its accept decision and caller identity on the subscribe sdpOffer that adds a call's track, and the SDK surfaces it as RtcStream.autoAccepted / from / fromType on onStreamAvailable. There is no separate streamAvailable RPC to correlate, so the two-phase ref juggling from the old branch is gone. - App: onStreamAvailable connects straight through when s.autoAccepted, else stashes the stream and prompts. Accept is purely client-side (play the stream the gateway already bridged); decline ends the call via hangupConnection. onStreamUnavailable clears all inbound state. - EndpointHandler: auto-accept toggle (a connect-time setMediaPreferences option), disabled once the endpoint exists; passes autoAccept into connect(). - IncomingCall: small presentational component + scss showing caller identity and Accept/Decline actions. - package.json: bump bandwidth-rtc to ^0.6.0 for the reworked SDK. There are no acceptStream/declineStream RPCs: accept needs no gateway signal and decline reuses the existing hangup path, so no gateway change is required. NOTE: bandwidth-rtc 0.6.0 is not yet published (this rides SDK PR #5). Test locally via `npm link bandwidth-rtc`; regenerate package-lock.json once the SDK release is cut. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.