Skip to content

Complete proxy vote deduplication and preserve queued vote IDs#1530

Merged
BenCodez merged 1 commit into
masterfrom
agent/consolidate-proxy-vote-dedup
Jul 19, 2026
Merged

Complete proxy vote deduplication and preserve queued vote IDs#1530
BenCodez merged 1 commit into
masterfrom
agent/consolidate-proxy-vote-dedup

Conversation

@BenCodez

@BenCodez BenCodez commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • deduplicate proxy offline/online cache entries by voteId without relying on vote delay
  • standardize persisted JSON on VoteId while retaining compatibility with legacy VoteID
  • preserve vote identity through the time-change queue and its JSON/SQL storage
  • add a nullable voteId SQL column using a database-compatible probe-and-migrate path
  • retain compatibility with older queued votes that do not contain an ID
  • add regression coverage for cache deduplication, legacy keys, distinct/null IDs, and queued vote persistence

Why

PRs #1528 and #1529 were stacked on intermediate feature branches. Merging them did not put their net changes onto master. This consolidation PR sits directly on current master and contains the remaining work after #1527.

Impact

Duplicate proxy deliveries with the same explicit vote ID are rejected before caching, and delayed votes retain the same identity when later processed. Legacy cache and queue records continue to load.

Validation

The branch is one commit directly ahead of current master, is automatically mergeable, and includes focused JUnit regression tests. GitHub Actions reruns after each force-update to verify the final squashed commit.

@BenCodez BenCodez closed this Jul 19, 2026
@BenCodez
BenCodez force-pushed the agent/consolidate-proxy-vote-dedup branch from 698a9d0 to 7f4a576 Compare July 19, 2026 19:29
@BenCodez BenCodez reopened this Jul 19, 2026
@BenCodez
BenCodez force-pushed the agent/consolidate-proxy-vote-dedup branch 2 times, most recently from c237059 to 44277a3 Compare July 19, 2026 19:35
@BenCodez
BenCodez force-pushed the agent/consolidate-proxy-vote-dedup branch from 44277a3 to 4ee7af2 Compare July 19, 2026 19:38
@BenCodez
BenCodez marked this pull request as ready for review July 19, 2026 19:42
@BenCodez
BenCodez merged commit 37c1842 into master Jul 19, 2026
4 checks passed
@BenCodez
BenCodez deleted the agent/consolidate-proxy-vote-dedup branch July 19, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant