ENG-2459 - Change 's3' dataSourceDescriptor and secretType to 'aws'#3
Open
chandrashekhar07 wants to merge 1 commit into
Open
ENG-2459 - Change 's3' dataSourceDescriptor and secretType to 'aws'#3chandrashekhar07 wants to merge 1 commit into
chandrashekhar07 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the naming convention by changing the dataSourceDescriptor and secretType values from "s3" to "aws" throughout the AWS S3 documentation. This aligns the terminology to be more consistent with AWS branding and likely reflects a broader system change to use "aws" as the identifier for AWS-related services.
- Updates all occurrences of
secretType: "s3"tosecretType: "aws" - Changes all instances of
dataSourceDescriptor: "s3"todataSourceDescriptor: "aws" - Updates descriptive text referencing "s3" secrets to reference "aws" secrets
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| launch-with-bytenite/data-sources/aws-s3.md | Updates S3-specific documentation to use "aws" instead of "s3" for secret types and data source descriptors |
| launch-with-bytenite/data-sources/README.md | Updates general data sources documentation examples to use "aws" instead of "s3" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.