Skip to content

ENG-2459 - Change 's3' dataSourceDescriptor and secretType to 'aws'#3

Open
chandrashekhar07 wants to merge 1 commit into
gitbook-syncfrom
aws-datasource
Open

ENG-2459 - Change 's3' dataSourceDescriptor and secretType to 'aws'#3
chandrashekhar07 wants to merge 1 commit into
gitbook-syncfrom
aws-datasource

Conversation

@chandrashekhar07

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the naming convention by changing the dataSourceDescriptor and secretType values from "s3" to "aws" throughout the AWS S3 documentation. This aligns the terminology to be more consistent with AWS branding and likely reflects a broader system change to use "aws" as the identifier for AWS-related services.

  • Updates all occurrences of secretType: "s3" to secretType: "aws"
  • Changes all instances of dataSourceDescriptor: "s3" to dataSourceDescriptor: "aws"
  • Updates descriptive text referencing "s3" secrets to reference "aws" secrets

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
launch-with-bytenite/data-sources/aws-s3.md Updates S3-specific documentation to use "aws" instead of "s3" for secret types and data source descriptors
launch-with-bytenite/data-sources/README.md Updates general data sources documentation examples to use "aws" instead of "s3"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants