Skip to content

[CBRD-26996] Fix CAS signal and cancel safety in broker#7394

Open
gg582 wants to merge 4 commits into
CUBRID:developfrom
gg582:feature/cbrd-26996-cas-signal
Open

[CBRD-26996] Fix CAS signal and cancel safety in broker#7394
gg582 wants to merge 4 commits into
CUBRID:developfrom
gg582:feature/cbrd-26996-cas-signal

Conversation

@gg582

@gg582 gg582 commented Jul 3, 2026

Copy link
Copy Markdown
Member

http://jira.cubrid.org/browse/CBRD-26996

Purpose

N/A

Implementation

N/A

Remarks

N/A

@gg582 gg582 requested a review from beyondykk9 as a code owner July 3, 2026 04:37
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

❌ TC Merge Gate — Merge Blocked

One or more TC PRs are still open. Please merge or close them before merging this PR.

TC Repositories & Branches:

  • cubrid-testcases: TC PR tc/pr-7394 is open (draft) — must be merged or closed first
  • cubrid-testcases-private-ex: TC PR tc/pr-7394 is open (draft) — must be merged or closed first

Steps to unblock:

  1. Merge or close all TC PRs listed above.
  2. Re-run this check: Actions tab → TC Merge Gate → Re-run failed jobs

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🧪 TC Test Environment Ready

CircleCI Testing:

  • CircleCI will automatically test using the branches below.

TC Repositories & Branches:

Next Steps:

  1. Wait for CircleCI tests to complete
  2. If CircleCI tests failed, please check the test results and fix the issues.
  3. When ready to merge this PR, please merge the TC PR first, then merge this PR.

@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "[CBRD-26996] Fix CAS signal and cancel s..." | Re-trigger Greptile

Comment thread src/broker/cas.c
Comment on lines +1129 to +1132
/* Process a query-cancel signal that arrived while the request header was
* being read. The actual interrupt is applied here in normal thread context,
* because signal-handler-safe functions are too limited for db_set_interrupt. */
query_cancel_process ();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Windows 빌드 실패 가능성: 미선언 함수 호출

query_cancel_process()#if !defined(WINDOWS) 가드 없이 호출되고 있으나, cas_common_main.h에서의 선언은 #if !defined(WINDOWS) 블록 내부에만 있습니다. Windows 빌드에서는 함수 선언이 보이지 않아 C99 기준으로 implicit function declaration 오류가 발생합니다. cas_common_main.c에 Windows 스텁(assert(0))이 존재하더라도, 헤더에 선언이 없으면 컴파일러가 이를 거부합니다.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큐브리드는 윈도우 빌드를 더이상 지원하지 않으므로 상관 없음.

Comment thread src/broker/cas.c Outdated
Comment thread src/broker/cas_common_main.c
gg582 and others added 3 commits July 3, 2026 14:36
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "Merge branch 'CUBRID:develop' into featu..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants