Fix ensureLoadedAndValid overwrite#713
Closed
jcw780 wants to merge 2 commits into
Closed
Conversation
Member
|
Rebased and squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Lithium's ensureLoadedAndValid overwrite
Correct chunk loading conditions and loading order of ensureLoadedAndValid.
Vanilla loads when chunk has empty sections or invalid PoiSections - current implementation is the opposite (likely missed the !)
Vanilla checks the sections in x then y then z - current Lithium implementation checks y, z, then x.
This results in chunk loading order differences to vanilla.
While it is unclear that anything is affected by this, I am opting to fix this just in case.