CMLDEV-1266: Fix virl2_client and server endpoint drift#234
Conversation
vprysiaz
commented
Jun 1, 2026
vprysiaz
commented
- use PUT instead of GET for labs/{lab_id}/bootstrap API
- removed dict annotation for licensing:update_features
- removed "{lab}/links/{id}/state" from Link._URL_TEMPLATES
- use PUT instead of GET for labs/{lab_id}/bootstrap API
- removed dict annotation for licensing:update_features
- removed "{lab}/links/{id}/state" from Link._URL_TEMPLATES
| "link": "{lab}/links/{id}", | ||
| "check_if_converged": "{lab}/links/{id}/check_if_converged", | ||
| "state": "{lab}/links/{id}/state", | ||
| "start": "{lab}/links/{id}/state/start", |
There was a problem hiding this comment.
[Bug (Pre-existing) - Confidence: 95%] H4 from CMLDEV-1266 is not addressed in this PR. pcap_packet is still pcap/{id}/packets/{packet_id} (line 55) but production pcapdemux and the CML UI use singular /packet/{packet_id} (golang/pkg/pcapdemux/router.go:19). get_capture_packet() will 404 against a real deployment.
Suggested fix:
"pcap_packet": "pcap/{id}/packet/{packet_id}",
| def update_features(self, features: list[dict[str, int]]) -> None: | ||
| """Update licensing feature's explicit count in reservation mode. | ||
|
|
||
| :param features: Feature names to counts, or list of such mappings. |
There was a problem hiding this comment.
[Nit (New) - Confidence: 90%] Docstring still says "Feature names to counts, or list of such mappings" after the signature was tightened to list[dict[str, int]] only. Update :param features: to describe the list shape.
AI-Assisted Code Review Summary
Linked Jira: CMLDEV-1266 Paired server PR: simple #4320 Scope checkH3 bootstrap GET→PUT, H5 Critical (must fix)
Minor (negligible / nits)
Things done well
Land this PR (with H4 fix) before merging simple #4320 submodule bump. |
2 participants
