Feature: Added Unfinished Upgrades#58
Open
zzhalex233 wants to merge 13 commits into
Open
Conversation
- Add magnet, void, refill, compacting, everlasting, jukebox, tool swapper, tank, pump, battery, and anvil upgrades with advanced variants - Register upgrade capabilities, wrappers, items, recipes, models, textures, and localization - Extend backpack storage with fluid, energy, filtering, stash, and upgrade lookup support - Rework the backpack GUI with scrollable storage, inline settings mode, upgrade tabs, and side controls - Add backpack settings, item display settings, displayed item rendering, and item insert (+/-) - Synchronize upgrade insert/remove state across tabs, toggles, tank controls, battery controls, and storage layout
# Conflicts: # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/block/BackpackBlock.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/capability/BackpackWrapper.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/client/gui/UpgradeSlotUpdateGroup.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/sync/UpgradeSlotSH.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/tileentity/BackpackTileEntity.kt # src/main/resources/assets/retro_sophisticated_backpacks/lang/zh_cn.lang
- Align captured mob footprint selection with upstream scoring - Rework captured mob slot rendering, ordering, lighting, and orientation - Keep captured mob hitboxes and release hints aligned with the rendered slot
…atedBackpack # Conflicts: # .gitignore # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/capability/BackpackWrapper.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/capability/upgrade/PumpUpgradeWrapper.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/client/gui/widgets/BackpackInventoryScrollWidget.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/client/gui/widgets/MobCatcherInventoryControlWidget.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/client/gui/widgets/slot/BackpackSlot.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/client/gui/widgets/upgrade/BatteryUpgradeWidget.kt # src/main/kotlin/com/cleanroommc/retrosophisticatedbackpacks/client/gui/widgets/upgrade/TankUpgradeWidget.kt
- resize backpack slot rows from scaled screen height - anchor player inventory and side tabs to corrected gui positions - restrict matched transfers to existing matching stacks or memory slots
- merge CleanroomMC 1.1.3 backpack naming and entity access changes - keep local upgrade ticking, gui rebuild, fluid, energy, and mob catcher behavior - carry upstream mob backpack spawn config and gui open target handling
- Add visual backpack tooltip sections for inventory contents, upgrades, fluids, and energy - Rework tank upgrade container filling and draining to follow bucket-style transfer behavior - Fix battery gauge texture layering and charge rendering - Render quick stash +/- overlays in container foreground so survival inventory shows them
- Rework tool swapper selection, manual swap packets, and advanced filter handling - Fix backpack scrollbar width and storage GUI right-edge alignment
Member
|
Thanks for your contribution towards Retro Sophisticated Backpack, I appreciate your PR's general goal, but due to several reasons, I'm not going to further review nor merge this PR:
I will not close the PR for now, but I would like to have each upgrade implementations / gui rework to be individual PRs for me to better review the changes. Additionally, PLEASE EXPLICITLY STATE THE USE OF AI, otherwise I might just close the issue next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add:
magnet_upgrade / advanced_magnet_upgrade
void_upgrade / advanced_void_upgrade
refill_upgrade / advanced_refill_upgrade
compacting_upgrade / advanced_compacting_upgrade
everlasting_upgrade
jukebox_upgrade / advanced_jukebox_upgrade
tool_swapper_upgrade / advanced_tool_swapper_upgrade
tank_upgrade
pump_upgrade / advanced_pump_upgrade
battery_upgrade
anvil_upgrade
mob_catcher_upgrade / advanced_mob_catcher_upgrade
and rework backpack gui a bit