fix: allow decimal values for exercise duration#1664
Conversation
PR Validation ResultsChange Detection
✅ All checks passed. Thank you! |
There was a problem hiding this comment.
Code Review
This pull request enables fractional (decimal) durations for exercise entries, sets, and workout templates across the database, web frontend, and mobile applications. Key changes include migrating database duration columns from integer to numeric, adopting a NumericInput component in the web frontend, updating mobile input keyboards to decimal-pad, and adjusting the mobile display logic to handle non-integer durations. Feedback was provided on the mobile detail screen to display durations with up to two decimal places instead of rounding to one, ensuring consistency with the web application's precision.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
54c01e3 to
ab998b1
Compare
|
How will the decimal points be treated? |
Tip
Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run
pnpm run validateto check for any errors.PRs that include tests and clear screenshots are highly preferred!
Note: AI-generated descriptions must be manually edited for conciseness. Do not paste raw AI summaries.
Description
Duration of exercise (sets, cardio) was not allowing values to be have decimal places
There was some drift between the backup sql and migrations. Now a new migration fixes them and changes these columns from int to numeric
Linked Issue: Closes #1497
How to Test
PR Type
Checklist
All PRs:
New features only:
Frontend changes (
SparkyFitnessFrontend/):pnpm run validateand it passes.en) translation file.Backend changes (
SparkyFitnessServer/):rls_policies.sqlfor any new user-specific tables.UI changes (components, screens, pages):
Mobile changes (
SparkyFitnessMobile/):Screenshots
Click to expand
Before
After
Notes for Reviewers