Skip to content

London | 26-ITP-May | Daniel Mears | Sprint 2 | Wireframe#1439

Open
djmears-dev wants to merge 5 commits into
CodeYourFuture:mainfrom
djmears-dev:feature/wireframe1
Open

London | 26-ITP-May | Daniel Mears | Sprint 2 | Wireframe#1439
djmears-dev wants to merge 5 commits into
CodeYourFuture:mainfrom
djmears-dev:feature/wireframe1

Conversation

@djmears-dev

@djmears-dev djmears-dev commented Jun 10, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Updated my wireframe task

@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit da75697
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a29d47c2f9f1600080abaef
😎 Deploy Preview https://deploy-preview-1439--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@djmears-dev djmears-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 10, 2026
@djmears-dev djmears-dev deleted the feature/wireframe1 branch June 10, 2026 01:52
@djmears-dev djmears-dev restored the feature/wireframe1 branch June 10, 2026 17:33
@djmears-dev djmears-dev reopened this Jun 10, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error free and well formatted. Form layout matches the wireframe well.

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • Three of the checkboxes in the PR description are not formatted correctly in Markdown syntax. Can you fix them?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026
@djmears-dev

Copy link
Copy Markdown
Author

Have now updated the footer so it is fixed at the bottom of the page

@djmears-dev djmears-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 10, 2026
@cjyuan

cjyuan commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Changes look good.

Three of the checkboxes in the PR description are not formatted correctly in Markdown syntax. Can you fix them?

I will mark this PR as "Complete" first.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 10, 2026
@djmears-dev

Copy link
Copy Markdown
Author

Thanks CJ, all updated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants