London | 26-ITP-May | Mandip Sanger | Sprint 1 | Form Contols by mandipsanger · Pull Request #1440 · CodeYourFuture/Module-Onboarding

mandipsanger · 2026-06-10T11:22:36Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed Form Controls task.

netlify · 2026-06-10T11:22:44Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`3cc5aa8`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2c5a364ab9fe0008bda0cd
😎 Deploy Preview	https://deploy-preview-1440--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Poonam-raj · 2026-06-10T14:32:59Z

-    </footer>
-  </body>
-</html>
+  <html lang="en"User-agent: *


What does <html lang="en"User-agent: * Allow: /> mean?

oh my bad. I was auto complete.

Poonam-raj · 2026-06-10T14:33:54Z

+  <header>
+    <h1></h1>
+  </header>


What is this header doing? There's no text here. Empty elements should be removed

Poonam-raj · 2026-06-10T14:35:13Z

+    </select>
+  </div>
+
+  <input type="submit" value="Submit">


I would have expected this to be a submit button
This tag is also not closed.

Poonam-raj · 2026-06-10T14:35:47Z

+  <div>
+    <p>Please select a size</p>
+
+    <label for="size">Choose a size:</label>
+    <select name="size" id="size">
+      <option value="xs">Extra Small</option>
+      <option value="small">Small</option>
+      <option value="medium">Medium</option>
+      <option value="large">Large</option>
+    </select>
+  </div>


How come you decided not to wrap this section in a fieldset tag but you wrapped lines 30 - 41 in a fieldset tag?

Thank you I think I have fixed the issues.

Could you please review my PR so I can submit the enrollment form.

Poonam-raj · 2026-06-10T14:37:18Z

+      <option value="xs">Extra Small</option>
+      <option value="small">Small</option>
+      <option value="medium">Medium</option>
+      <option value="large">Large</option>


It could be useful here to have a default select option so that the form doesn't default to picking a size accidentally. E.g. if i don't pick a size, the form will submit XS but I might not want XS. It would be better to have a default value that doesn't let the user submit and forces them to select a size.

Poonam-raj

Some issues:

When I leave all the inputs empty and click submit the page reloads like it has submitted. I get no messages saying anything is wrong or that I've missed inputs, but I should get some feedback like that.
When I submit less than two characters for the Name field I get a generic message that doesn't tell me what is actually wrong (screenshot)

When i do input two characters in the Name field, the form lets me submit but I shouldn't be able to because Email and the other fields aren't filled out yet.
Throughout your form you lack 'required' tags which would mean the form cannot submit unless the user inputs into the fields. Please look into this.

Poonam-raj · 2026-06-12T12:59:30Z

+          <fieldset>
+            <legend>Please select your color</legend>
+
+            <input type="radio" id="black" name="color" value="Black" />
+            <label for="black">Black</label>
+
+            <input type="radio" id="beige" name="color" value="Beige" />
+            <label for="beige">Beige</label>
+
+            <input type="radio" id="red" name="color" value="Red" />
+            <label for="red">Red</label>
+          </fieldset>


I can currently submit this form without selecting a colour - please amend

I don't think we had to add color only selected was needed.

I have fixed with required.

Poonam-raj

You have successfully addressed my concenrs about the form from before. But one last thing remaining with the colour selection

cjyuan · 2026-06-12T19:28:07Z

@Poonam-raj The latest changes made by @mandipsanger looks good to me. Because the Onboarding deadline is today, hope you don't mind I mark this PR as "Complete" first.

mandipsanger added 13 commits May 30, 2026 13:51

I added my name to html

3e0a907

form control initial version

a00382e

fix name input

bd4b9d4

add pattern validation

3d5a056

fix errors

11f94cf

fix errors

3fb6770

remove action in form

ac42a05

add style sheet

37f812a

change color

9171f0e

fix errors

a384733

final version

4c7d762

final version with correction

b091bfa

fix file locking errors

4bee091

This comment has been minimized.

Sign in to view

mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 10, 2026

fix revert wireframes html file

fea1e89

mandipsanger added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 10, 2026

Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026

Poonam-raj reviewed Jun 10, 2026

View reviewed changes

mandipsanger added 2 commits June 10, 2026 16:45

add h1 and fix errors

110cfc5

fix form elements

40013cb

mandipsanger mentioned this pull request Jun 10, 2026

26-ITP-May | Onboarding | Mandip Sanger mandipsanger/My-Coursework-Planner#49

Closed

mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 10, 2026

kfklein15 requested a review from Poonam-raj June 12, 2026 10:59

Poonam-raj reviewed Jun 12, 2026

View reviewed changes

Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 12, 2026

fix colour input

bc41e3d

mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 12, 2026

mandipsanger mentioned this pull request Jun 12, 2026

I have fixed it please review so I can close the issue. #1445

Closed

mandipsanger added 7 commits June 12, 2026 16:48

fix html tag

bde7096

Add xl and xxl

e6e092c

fix size errors

13c95b9

fix errors

8bd20f0

color corrections

3bdb7dd

Fix display error

b9b22e6

style sheet /size changes

607ff0e

kfklein15 requested a review from Poonam-raj June 12, 2026 19:01

change the option value

3cc5aa8

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 12, 2026

Uh oh!

Conversation

mandipsanger commented Jun 10, 2026

Learners, PR Template

Changelist

Uh oh!

netlify Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Poonam-raj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Poonam-raj left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Jun 10, 2026 •

edited

Loading