Glasgow | 25-ITP-May | Wing Ting Huang | Sprint 1 | Form-Controls#1448
Open
huangwtings-hub wants to merge 2 commits into
Open
Glasgow | 25-ITP-May | Wing Ting Huang | Sprint 1 | Form-Controls#1448huangwtings-hub wants to merge 2 commits into
huangwtings-hub wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
huangwtings-hub
added
the
Needs Review
cjyuan
reviewed
Jun 12, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Just one request:
Currently, when a user input does not match the pattern, the browser shows only "Please match the requested format". Could you find a way to inform the user what the expected format is?
cjyuan
added
Reviewed
- Add title to Customer Name field explaining the 2-character requirement - Add title to Email field for clarity - Add title attributes to Colour and Size select fields - Improves UX by showing users what format is expected when validation fails Fixes feedback from cjyuan
huangwtings-hub
added
the
Needs Review
Contributor
|
Changes look good. When you have some time, try sharing your code with an AI tool and asking how the semantics of the form could be improved. It's a great way to discover best practices and learn new techniques that you might not have considered. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Change list
Re-do Form-Controls to make it clear