Skip to content

Cape Town | May-ITP-2026 | Enice Mutanda| Sprint 2 | Wireframe#1449

Open
Enice-Codes wants to merge 2 commits into
CodeYourFuture:mainfrom
Enice-Codes:feature/wireframe-clean
Open

Cape Town | May-ITP-2026 | Enice Mutanda| Sprint 2 | Wireframe#1449
Enice-Codes wants to merge 2 commits into
CodeYourFuture:mainfrom
Enice-Codes:feature/wireframe-clean

Conversation

@Enice-Codes

@Enice-Codes Enice-Codes commented Jun 12, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Changed image
fixed footer positioning
used CSS Grid to style layout
Added semantic HTML structure
Improved layout

I had git issues with my work so i had to delete my old work and fork it again
updated Html. This is a new PR request as I had to redo my work in order to resolve the merge conflicts that I was struggling to fix in my old repo. This is now a new repository that I cloned.

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 3f8d368
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2c545d6f66a00008a533a5
😎 Deploy Preview https://deploy-preview-1449--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 83 (🔴 down 17 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Enice-Codes Enice-Codes added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 12, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • To better match the wireframe, can you keep the page title and the text beneath it centered on the page?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 12, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 12, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Can you remove all unused files from this branch to keep the branch clean? I will mark this PR "Complete" first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image still needed?

Comment thread Wireframe/Classroom.jpg

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a better practice, in the context of webpages or web applications, to use only lowercase letters in file names.

For more info, do use AI to find out why (when you have time).

No change needed for this exercise.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants