feat(config): publish honors repo visibility + API to manage the trust config#2155
Merged
rubenvdlinde merged 1 commit intoJul 26, 2026
Merged
Conversation
…t config Two gaps in the store's governance/usability: - **Publish now honors visibility.** `publish(..., private: bool)` and the controller's `visibility: private` param let a freshly created store repo be private (previously every store repo was forced public). Defaults to public (backward-compatible); the token needs rights to create private repos. - **The trust controls are API-manageable, not occ-only.** New admin-gated `GET/PUT /api/federated-config/trust` read and write the org's source allowlist, trusted publisher keys, and publish/install group lists — plus a `trustKey` convenience that appends a public key to the trusted-keys list (idempotent). Non admins get 403; an unknown field is a 400. This is the backend a governance settings UI needs (the config keys previously required `occ`). Unit: trust read/write round-trip (set fields, append keys idempotently, unknown field throws). Live-verified on 8080: admin GET/PUT + trustKey append work, non-admin GET is 403, unknown field is 400.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 555/555 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-07-26 19:21 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes two governance/usability gaps in the store:
publish(..., private:)+ controllervisibility: privatecreate a private store repo instead of always-public (default public, backward-compatible).GET/PUT /api/federated-config/trustfor the source allowlist, trusted publisher keys, and publish/install group lists, plus atrustKeyappend convenience. Previouslyocc-only. Non-admin → 403; unknown field → 400.Unit test (trust round-trip) + live-verified on 8080 (admin GET/PUT/trustKey, non-admin 403, unknown-field 400).