fix: fetch bookmark IDs on boot so icons reflect saved state on any page#134
Merged
Conversation
…ny page Without this, idsBookmarked was always empty until the user visited the bookmarks tab, causing saved docs to appear un-bookmarked on search/chat and toggleBookmark to add instead of remove. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment on lines
+39
to
+49
| const fetchBookmarkIds = async () => { | ||
| try { | ||
| const result = await baseGetAxios('/user/bookmarks'); | ||
| idsBookmarked.value = (result.bookmarks ?? []).map( | ||
| (b: { document_id: string }) => b.document_id | ||
| ); | ||
| } catch (error) { | ||
| console.error('Failed to fetch bookmark IDs:', error); | ||
| } | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
I just realized that this method is not needed , since it does the same as getBoomarks that is on mine 50.
To avoid having duplicated code, the getBookmarks one should be used.
Contributor
Author
There was a problem hiding this comment.
good catch. see newest commit. thanks.
fetchBookmarkIds was a subset of getBookmarks — both set idsBookmarked, getBookmarks also loads full document payloads. Using getBookmarks directly removes the duplicate and pre-loads bookmark data so the bookmarks tab renders instantly on first visit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchBookmarkIds()to the bookmarks store — callsGET /user/bookmarks, extracts IDs only (no document payloads), and setsidsBookmarkedApp.vue's boot sequence in parallel with existing init calls, so it costs no extra timeWhy
idsBookmarkedwas always empty on page load until the user visited the bookmarks tab. This caused already-saved documents to appear un-bookmarked on the search/chat pages, and clicking the bookmark icon would try to add a duplicate instead of removing.Test plan
🤖 Generated with Claude Code