Fix: MAIN_GROUP assignment without GROUP parameter for --from-source#67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the tool does not assign any group to the created items when using "--from-source" with "--target-group" or a MAIN_GROUP defined in the source file. Groups are only assigned, if the item also has a "GROUP" definition, in that case this GROUP is added as a sub-group to the main-group.
According the ASAP2 Toolset documentation, the MAIN_GROUP will be used for all items as default group:
https://cdn.vector.com/cms/content/products/asap2/Docs/ASAP2Tool-Set_Manual_EN.pdf (page 33)
The code currently defined "CREATED" as default value for the main-group if no main-group was specified via MAIN_GROUP or "--target-group". With this change, the the new items are always assigned to the main_group. The default "CREATED" main_group value was kept, resulting in new items to be assigned to the group "CREATED" if no other main-group was defined (via MAIN_GROUP or "--target-group").