build: stop pulling setuptools into runtime dependencies - #115
build: stop pulling setuptools into runtime dependencies#115federicobond wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the package’s dependency metadata so that setuptools is no longer propagated as a runtime requirement to downstream consumers, while still ensuring it is available for build-time packaging.
Changes:
- Removed
setuptoolsfromrequirements.txtso it no longer ends up ininstall_requires. - Added a PEP 517
[build-system]section topyproject.tomlto declaresetuptoolsas a build requirement.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements.txt | Removes setuptools from the dependency list that is used to populate runtime install_requires. |
| pyproject.toml | Declares setuptools as the PEP 517 build backend requirement (but currently missing wheel). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
|
Looks like you've got some test failures from removing responses. https://github.com/DevCycleHQ/python-server-sdk/actions/runs/30093667618/job/90023718232?pr=115 |
fac1135 to
1cbb495
Compare
|
Ah right, sorry about that. I added |
setuptoolswas listed inrequirements.txtand thus propagated toinstall_requires, forcing it as a runtime dependency for downstream installs even though it is never imported at runtime.Remove it from requirements.txt and instead declare it as a build-time requirement only.
Update: also removed
responsesfromrequirements.txtwhich is already declared inrequirements.test.txt