Integrating PR #8#12
Merged
Merged
Conversation
PREF_PREFERRED_DNS_MODE was only ever written once, at first app launch, so WifiMonitoringService.restorePreferredDns() could restore to a stale mode after leaving a blacklisted Wi-Fi network instead of the user's actual current preference. DnsManager.togglePrivateDns() now keeps that preference in sync on every genuine user-driven toggle (skipping the auto-blacklist/whitelist path, which is SSID-scoped and shouldn't change the global preference).
…lacklist - Fix Private DNS not turning back on after leaving a blacklisted network.
- Better handling of out-of-app settings changes - Prevent network errors with better fallback after keystore change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the hardened blacklist settings restore introduced in #8 with some extra safeguards.