Require user authentication for Dataplayer features and updates#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the authentication experience and error handling for gated pages (Data Sandbox, chat, and profile). It ensures users are returned to the page they came from after logging in, and prevents misleading errors from showing when not authenticated. The main changes include a new post-login redirect mechanism, improved login prompts, and better handling of unauthenticated states in the Data Sandbox.
Authentication flow improvements:
authRedirect.tshelper module that stashes the intended page insessionStoragebefore login and returns the user to that page after authentication. (src/lib/authRedirect.ts)ChatPage,ProfilePage, andDataplayerPage) to use the newloginWithReturnfunction, ensuring users return to their original page after logging in. (src/pages/ChatPage.tsx, [1];src/pages/ProfilePage.tsx, [2];src/pages/DataplayerPage.tsx, [3]Data Sandbox (Dataplayer) error handling:
useDatasethook to delay API calls until the user is authenticated, preventing "failed to fetch files" errors when the user is not logged in. (src/hooks/useDataplayerHooks.ts, [1] [2] [3]src/pages/DataplayerPage.tsx, [1] [2] [3]Changelog updates:
CHANGELOG.mdfor version 0.8.5 to document the improved login flow and error handling for gated pages.These changes make the authentication experience smoother and prevent confusing error messages for users accessing restricted pages while logged out.