Data time subsetting#64
Open
SarahAlidoost wants to merge 21 commits into
Open
Conversation
Collaborator
|
See comment in PR #54 on replacing month positional encoding with a month-of-year feature in cyclical time embedding |
Merged
Member
Author
|
@meiertgrootes and @rogerkuou Hi, this PR is ready for review. Thanks! After merging #63 , I can update the notebook in this PR. |
Open
rogerkuou
approved these changes
Jul 7, 2026
rogerkuou
left a comment
Collaborator
There was a problem hiding this comment.
Hi @SarahAlidoost, thanks for the nice implementation.
I just have two small comments on an inline doc, and use of pytest fixture. Please feel free to merge after fixing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #62
closes #42
🔴 this branch should be merged after #63
In this PR:
So the model is already learning a seasonal climatology and modulation, not relying on a fixed per-month correction.