GH-373 Add opponent placeholder in combat notification#373
Merged
Conversation
CitralFlo
commented
Apr 10, 2026
CitralFlo
commented
Member
Signed-off-by: Michał Wojtas <wojtas.michal90@gmail.com>
CitralFlo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Minecraft version to 1.21.11 and introduces a new {OPPONENT} placeholder for combat notifications, allowing players to see who tagged them. The implementation includes a configurable placeholder for unknown players. Feedback was provided to ensure that the {OPPONENT} placeholder does not display the player's own name in scenarios involving self-tagging, such as using ender pearls.
Jakubk15
approved these changes
Apr 12, 2026
imDMK
reviewed
Apr 13, 2026
…t/FightTask.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
vLuckyyy
requested changes
May 9, 2026
| }) | ||
| public Notice combatNotification = BukkitNotice.builder() | ||
| .actionBar("Combat ends in: <red>{TIME}</red>") | ||
| .actionBar("Combat ends in: <red>{TIME}</red> | Enemy: <red>{OPPONENT}</red> ⚔") |
Member
There was a problem hiding this comment.
I don't like that you set this as the default.
The goal is clear: a simple plugin for combat tagging, with advanced options
Rollczi
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.