Skip to content

vts data errors - 3 telescopes; broken job lib files.#77

Open
GernotMaier wants to merge 3 commits into
mainfrom
vts-data-errors
Open

vts data errors - 3 telescopes; broken job lib files.#77
GernotMaier wants to merge 3 commits into
mainfrom
vts-data-errors

Conversation

@GernotMaier

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets two error cases seen in VERITAS (“vts”) workflows: (1) telescope-footprint computation failing when configured telescopes are not present in an event chunk, and (2) joblib model artifacts being written without post-save validation.

Changes:

  • Add a post-save validation step for model joblib artifacts (atomic temp-file write → validate → rename).
  • Fix _calculate_array_footprint sizing to use configured telescope IDs rather than only those seen in the current event chunk.
  • Extend unit tests to cover the new footprint behavior and model-save validation failure handling.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File Description
src/eventdisplay_ml/models.py Writes models atomically and runs a validation subprocess before finalizing the output joblib.
src/eventdisplay_ml/data_processing.py Uses tel_config["tel_ids"] to size the array-footprint lookup to avoid indexing failures when some configured telescopes are absent in a chunk.
tests/test_models_helpers.py Updates model-save test inputs and adds a test for rejecting failed validation.
tests/test_data_helpers.py Adds coverage for footprint computation when a configured telescope is absent from the event telescope list.

Comment thread src/eventdisplay_ml/models.py
Comment thread tests/test_models_helpers.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread src/eventdisplay_ml/_model_validation.py
@GernotMaier
GernotMaier marked this pull request as ready for review July 20, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants