vts data errors - 3 telescopes; broken job lib files.#77
Open
GernotMaier wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets two error cases seen in VERITAS (“vts”) workflows: (1) telescope-footprint computation failing when configured telescopes are not present in an event chunk, and (2) joblib model artifacts being written without post-save validation.
Changes:
- Add a post-save validation step for model joblib artifacts (atomic temp-file write → validate → rename).
- Fix
_calculate_array_footprintsizing to use configured telescope IDs rather than only those seen in the current event chunk. - Extend unit tests to cover the new footprint behavior and model-save validation failure handling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/eventdisplay_ml/models.py |
Writes models atomically and runs a validation subprocess before finalizing the output joblib. |
src/eventdisplay_ml/data_processing.py |
Uses tel_config["tel_ids"] to size the array-footprint lookup to avoid indexing failures when some configured telescopes are absent in a chunk. |
tests/test_models_helpers.py |
Updates model-save test inputs and adds a test for rejecting failed validation. |
tests/test_data_helpers.py |
Adds coverage for footprint computation when a configured telescope is absent from the event telescope list. |
GernotMaier
marked this pull request as ready for review
July 20, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.