Renumber simplex reference cells#1028
Draft
mscroggs wants to merge 9 commits into
Draft
Conversation
Member
|
This has to be introduced very carefully, as this will break all IO permutations we have made in DOLFINx and any other IO library. |
mscroggs
changed the title
Member
Furthermore, this will break any checkpoint made by adios4dolfinx or io4dolfinx made prior to this merge, as this will affect the element dof layout and I guess the cell permutations and facet permutation will differ? |
Member
Author
Yes, hence "draft" for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renumber the entities of the triangle and tetrahedron reference cells to follow the consistent convention proposed in #1020.
Following this PR. The triangle and tetrahedron reference cells are numbered like this:
For reference, the numbering before this PR is: