fix: add origin check to mockServiceWorker.js message handler#49
Merged
Conversation
Closes the js/missing-origin-check CodeQL alert instead of just excluding the file from scanning. Service workers only ever control same-origin clients, so this is defense-in-depth rather than a real gap, but it satisfies the check without changing behavior. Drops the paths-ignore added earlier now that the underlying finding is fixed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messagehandler infrontend/public/mockServiceWorker.js, closing thejs/missing-origin-checkCodeQL alert directly rather than just excluding the (MSW-generated) file from scanning.paths-ignoreadded for this file in the CodeQL workflow now that the underlying finding is actually fixed.npx msw initand its header says not to hand-edit it — if it's ever regenerated, this check will need to be reapplied (or upstreamed to mswjs/msw).Test plan
pnpm dev, confirm mocked responses still intercepted)