fix: skip requirement metadata in main specs#1178
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMarkdownParser now detects and skips requirement metadata lines (matching ChangesRequirement Text Extraction with Metadata Skipping
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
Approved. I checked the parser and validation paths directly: main spec validation gets requirement text from MarkdownParser.parseRequirements(), while delta validation already has its own metadata-skipping extractor, so this is the right layer for #418. Focused parser and validation tests pass locally: pnpm exec vitest run test/core/parsers/markdown-parser.test.ts test/core/validation.test.ts.
Summary
Why
Main specs with structured metadata before the requirement body can currently fail validation because the parser treats the first metadata line as the requirement text and misses the later SHALL/MUST statement.
Fixes #418.
Validation
Summary by CodeRabbit