Skip to content

fix: use checkbox markers in tool multiselect#1179

Open
leno23 wants to merge 1 commit into
Fission-AI:mainfrom
leno23:codex/fix-multiselect-checkbox-icons
Open

fix: use checkbox markers in tool multiselect#1179
leno23 wants to merge 1 commit into
Fission-AI:mainfrom
leno23:codex/fix-multiselect-checkbox-icons

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented Jun 5, 2026

Summary

  • render the searchable multi-select prompt with [x] and [ ] markers instead of radio-style circles
  • add coverage that verifies selected and unselected options use checkbox-style markers

Why

The init tool selector supports multiple selections, but circular markers make it look like a radio-button single-select control.

Fixes #647.

Validation

  • pnpm exec vitest run test/prompts/searchable-multi-select.test.ts

Summary by CodeRabbit

  • Style
    • Updated visual indicators in multi-select selection lists: selected items now display with a checkmark [x] and unselected items display with an empty box [ ] for improved clarity.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 879f36ab-71c4-42c2-be3b-78f017cae162

📥 Commits

Reviewing files that changed from the base of the PR and between 1b06fdd and eb3e94c.

📒 Files selected for processing (2)
  • src/prompts/searchable-multi-select.ts
  • test/prompts/searchable-multi-select.test.ts

📝 Walkthrough

Walkthrough

This PR updates the multi-select prompt UI to use checkbox-style indicators ([x] and [ ]) instead of radio-button-style symbols ( and ), aligning the visual representation with the multi-selection capability. A test suite validates the checkbox markers render and toggle correctly.

Changes

Checkbox Visual Update

Layer / File(s) Summary
Checkbox rendering and test validation
src/prompts/searchable-multi-select.ts, test/prompts/searchable-multi-select.test.ts
Selection icon changed from radio buttons to checkbox markers with chalk styling ([x] for selected, [ ] for unselected). New test suite verifies checkbox markers render initially unchecked and update to checked after toggling selection via space key.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through checkboxes with glee,
No more radio buttons confusing the spree,
[x] marks the spot where selections align,
Multi-select clarity, now that's divine! ✓

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the searchable multi-select prompt to use checkbox markers instead of radio-style indicators.
Linked Issues check ✅ Passed The PR successfully implements the objective from #647: changing visual markers from radio-button style (◉/○) to checkbox style ([x]/[ ]) in the searchable multi-select prompt, matching visual affordance to multi-selection behavior.
Out of Scope Changes check ✅ Passed All changes are directly in-scope: modifications to the searchable-multi-select.ts prompt file and corresponding test coverage align exactly with the requirements in issue #647.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leno23 leno23 marked this pull request as ready for review June 5, 2026 10:04
@leno23 leno23 requested a review from TabishB as a code owner June 5, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenSpec agent selection should use checkboxes instead of radio buttons since allows multiple

1 participant