-
Notifications
You must be signed in to change notification settings - Fork 549
fix(onboarding): review-feedback polish #7989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c713a30
140cc85
4ed30e2
722c461
faf2a37
8c3e7ea
3c80f00
f489ef0
b0bbf5b
8be8e03
1202aef
a08c5c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ export type InlineInputProps = { | |
| } | ||
|
|
||
| // Onboarding-local inline editable value (GhostInput + pencil) for the welcome | ||
| // sentence: an action underline + pencil mark it editable, it commits on | ||
| // blur/Enter, and an empty value reverts. Shares the VariationKeyLabel inline | ||
| // sentence: a resting fill, action underline and pencil mark it editable; it | ||
| // commits on blur/Enter, and an empty value reverts. Shares the VariationKeyLabel inline | ||
| // edit's visual language but drops its buttons/validation to stay prose-like; | ||
| // feature-local for now, both should converge on one primitive. | ||
| const InlineInput: FC<InlineInputProps> = ({ | ||
|
|
@@ -67,7 +67,7 @@ const InlineInput: FC<InlineInputProps> = ({ | |
| value={draft} | ||
| placeholder={label} | ||
| maxLength={maxLength} | ||
| aria-label={`${label} name`} | ||
| aria-label={`Edit ${label.toLowerCase()}`} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "name" in the accessible label makes Safari offer contact autofill over the field, so it reads "Edit flag" now. The e2e label change is the same fix. We also gave the field a fill so it's more visible when editing. |
||
| onChange={(e) => { | ||
| const raw = e.target.value | ||
| setDraft(transform ? transform(raw) : raw) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ Detect my stack, install the SDK, and wire ${featureName} into one place. Then r | |
|
|
||
| return ( | ||
| <> | ||
| <span className='text-default fw-semibold'> | ||
| <span className='text-default font-weight-semibold'> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kyle's catch: |
||
| Paste this into your AI coding agent’s chat | ||
| </span> | ||
| <div className='bg-surface-muted p-3 d-flex align-items-start gap-3 rounded-md'> | ||
|
|
@@ -50,7 +50,9 @@ Detect my stack, install the SDK, and wire ${featureName} into one place. Then r | |
| </Button> | ||
| </div> | ||
| <div> | ||
| <span className='text-default fw-semibold'>What happens next</span> | ||
| <span className='text-default font-weight-semibold'> | ||
| What happens next | ||
| </span> | ||
| <ul className='onboarding-connect__steps text-muted mt-2 mb-0'> | ||
| <li>Detects your stack: language, framework and package manager.</li> | ||
| <li>Installs the Flagsmith SDK and wires it into your code.</li> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| import React from 'react' | ||
| import Svg from './svg' | ||
|
|
||
| // Two-tone on purpose: the other logos are single-fill glyphs, but JS is a | ||
| // filled badge. Drawing the "JS" as solid black over the yellow square (rather | ||
| // than the shared wrapper's hole-punch, which shows the chip through it and | ||
| // washes out on a light chip) keeps it readable on both light and dark. Rounded | ||
| // so it reads as a badge. | ||
| export const JavascriptLogo = () => ( | ||
| <Svg color='#F7DF1E'> | ||
| <path d='M0 0h24v24H0V0zm22.034 18.276c-.175-1.095-.888-2.015-3.003-2.873-.736-.345-1.554-.585-1.797-1.14-.091-.33-.105-.51-.046-.705.15-.646.915-.84 1.515-.66.39.12.75.42.976.9 1.034-.676 1.034-.676 1.755-1.125-.27-.42-.404-.601-.586-.78-.63-.705-1.469-1.065-2.834-1.034l-.705.089c-.676.165-1.32.525-1.71 1.005-1.14 1.291-.811 3.541.569 4.471 1.365 1.02 3.361 1.244 3.616 2.205.24 1.17-.87 1.545-1.966 1.41-.811-.18-1.26-.586-1.755-1.336l-1.83 1.051c.21.48.45.689.81 1.109 1.74 1.756 6.09 1.666 6.871-1.004.029-.09.24-.705.074-1.65l.046.067zm-8.983-7.245h-2.248c0 1.938-.009 3.864-.009 5.805 0 1.232.063 2.363-.138 2.711-.33.689-1.18.601-1.566.48-.396-.196-.597-.466-.83-.855-.063-.105-.11-.196-.127-.196l-1.825 1.125c.305.63.75 1.172 1.324 1.517.855.51 2.004.675 3.207.405.783-.226 1.458-.691 1.811-1.411.51-.93.402-2.07.397-3.346.012-2.054 0-4.109 0-6.179l.004-.056z' /> | ||
| </Svg> | ||
| <svg viewBox='0 0 24 24' width={16} height={16} aria-hidden> | ||
| <rect width={24} height={24} rx={4} fill='#F7DF1E' /> | ||
| <path | ||
| fill='#000' | ||
| d='M22.034 18.276c-.175-1.095-.888-2.015-3.003-2.873-.736-.345-1.554-.585-1.797-1.14-.091-.33-.105-.51-.046-.705.15-.646.915-.84 1.515-.66.39.12.75.42.976.9 1.034-.676 1.034-.676 1.755-1.125-.27-.42-.404-.601-.586-.78-.63-.705-1.469-1.065-2.834-1.034l-.705.089c-.676.165-1.32.525-1.71 1.005-1.14 1.291-.811 3.541.569 4.471 1.365 1.02 3.361 1.244 3.616 2.205.24 1.17-.87 1.545-1.966 1.41-.811-.18-1.26-.586-1.755-1.336l-1.83 1.051c.21.48.45.689.81 1.109 1.74 1.756 6.09 1.666 6.871-1.004.029-.09.24-.705.074-1.65l.046.067zm-8.983-7.245h-2.248c0 1.938-.009 3.864-.009 5.805 0 1.232.063 2.363-.138 2.711-.33.689-1.18.601-1.566.48-.396-.196-.597-.466-.83-.855-.063-.105-.11-.196-.127-.196l-1.825 1.125c.305.63.75 1.172 1.324 1.517.855.51 2.004.675 3.207.405.783-.226 1.458-.691 1.811-1.411.51-.93.402-2.07.397-3.346.012-2.054 0-4.109 0-6.179l.004-.056z' | ||
| /> | ||
| </svg> | ||
| ) |
Uh oh!
There was an error while loading. Please reload this page.