Fix package version create Request#782
Merged
Merged
Conversation
- Resolve a Subscriber Package Version (04t) ancestor to its Package2Version (05i) ID, which the descriptor's ancestorId requires. - Include CalcTransitiveDependencies and IsDevUsePkgZipRequested (both false for now) in the Package2VersionCreateRequest. - Write zero-length directory entries in package.zip to mirror the layout the sf CLI produces. - Add an (empty) Profile type to package.xml, re-marshaling so the Profile <types> element is ordered before <version>. Extract the manifest and zip-directory logic into testable helpers and cover them with tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve a Subscriber Package Version (04t) ancestor to its
Package2Version (05i) ID, which the descriptor's ancestorId requires.
Include CalcTransitiveDependencies and IsDevUsePkgZipRequested
(both false for now) in the Package2VersionCreateRequest.
Write zero-length directory entries in package.zip to mirror the
layout the sf CLI produces.
Add an (empty) Profile type to package.xml, re-marshaling so the
Profile element is ordered before .
Extract the manifest and zip-directory logic into testable helpers and
cover them with tests.