larsb-p GENIEReweight development#49
Open
larsb-p wants to merge 25 commits into
Open
Conversation
…parameter implementation
…ors/GReWeightINuke.h
… rw.AdoptWghtCalc( xsec_ccqe_elff, new GReWeightNuXSecCCQEELFF ); in grwgh1p (think about this more later)
…enabled actual reweighting to the 2p-2h Martini model by inputting MartiniEricsonChanfrayMarteauMECPXSec2024 into placeholder for XSecShape_CCMEC_Martini dial
…onsidering the 2p2h Martini model and added normalsation for DecayAngMEC parameter with two tweak dials
…cia model and the energy transfer cut-off in the Martini model
…will be handled automatically in the code.
…ecShape_CCMEC and XSecShape_CCMEC_Martini dials
Member
|
I'm going to hold on on reviewing this until the related GENIE-MC/Generator#478 and GENIE-MC/Generator#472 conflicts are resolved |
…Martini-Ericson_Chanfray-Marteau model is input as default
…n GReWeightXSecMEC.cxx
…ied instead of divided (input default model gets up- or down-reweighted according to renormalised cross section ratio being greater or smaller to 1.)
…ng hard-coded xsec ratio tables to it reading the xsecs directly from the user's input cross-section spline xml-file. The user can now input multiple xml-files via the cross-sections option of grwght1p.
…RwghtNCorrelatedParams.cxx (matches original implementation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GENIEReweight branch "larsbp_update_to_GENIEv3_06_02" contains novel 2p-2h systematic uncertainty parameters, implemented in GENIEReweight version 1.04.02 alongside GENIE version 3.06.02. The available dials are:
The input model is the CCMEC Valencia, SuSAv2 or Martini-Ericson-Chanfray-Marteau model.