Skip to content

WIP: CI: Remove the workaround for crashes on Windows #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seisman wants to merge 8 commits into
base: main
Choose a base branch
from
+3 −26
Open

WIP: CI: Remove the workaround for crashes on Windows #4156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cde3c0
Revert "CI: Temporarily disable the Docs workflow on Windows (#4151)"
seisman Oct 12, 2025
f87ec06
Merge branch 'main' into ci/enable-docs-windows
yvonnefroehlich Mar 1, 2026
b90cff3
Merge branch 'main' into ci/enable-docs-windows
seisman May 23, 2026
607c26d
Merge branch 'main' into ci/enable-docs-windows
seisman Jun 4, 2026
98d81db
Merge branch 'main' into ci/enable-docs-windows
seisman Jun 5, 2026
f2c863b
Revert "CI: Allow Tests and Docs workflows to pass for segment fault …
seisman Jun 5, 2026
bc26fa9
Fix
seisman Jun 5, 2026
2ce8b39
Merge branch 'main' into ci/enable-docs-windows
seisman Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions .github/workflows/ci_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,25 +135,10 @@ jobs:
python -m pip install dist/*

- name: Build the HTML documentation
run: |
log_file="${RUNNER_TEMP}/sphinx-html.log"
make -C doc clean html 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then
echo "Sphinx HTML build exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue."
exit 0
fi
exit "${exit_code}"
run: make -C doc clean html

- name: Build the PDF documentation
run: |
log_file="${RUNNER_TEMP}/sphinx-pdf.log"
make -C doc pdf 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then
echo "Sphinx PDF build exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue."
exit 0
fi
run: make -C doc pdf

- name: Create the HTML ZIP archive and rename the PDF file
run: |
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,7 @@ jobs:

# Run the regular tests
- name: Run tests
run: |
log_file="${RUNNER_TEMP}/pytest.log"
make test PYTEST_EXTRA="-r P --reruns 2" 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then
echo "Tests exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue."
exit 0
fi
exit "${exit_code}"
run: make test PYTEST_EXTRA="-r P --reruns 2"

# Upload diff images on test failure
- name: Upload diff images if any test fails
Expand Down
Loading