apigee: document & test /28 support range for google_apigee_instance ip_range#17945
Open
xuchenma wants to merge 1 commit into
Open
apigee: document & test /28 support range for google_apigee_instance ip_range#17945xuchenma wants to merge 1 commit into
xuchenma wants to merge 1 commit into
Conversation
…e ip_range
Users with multiple /28s could not choose which support range google_apigee_instance
uses: the ip_range field only documented the /22 runtime block. The Apigee API's
ipRange actually accepts a comma-separated list of /22 and/or /28 blocks
("a.b.c.d/22,e.f.g.h/28"), so the value already passes through -- the gap was
documentation and lack of an example.
- Update the ip_range field description to document the /28 support range and the
comma-separated "/22,/28" input format.
- Add apigee_instance_ip_range_with_support_range_test, which reserves a /20 and
creates an instance with both an explicit /22 runtime range and an explicit /28
support range, proving the combined format works end to end.
Fixes hashicorp/terraform-provider-google#19501
BUG=369201169
Signed-off-by: Xuchen Ma <xuchenm@google.com>
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 1 week. Please take a look! Use the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google_apigee_organization/google_apigee_instanceusers with multiple /28s couldn't choose which /28 support range to use — theip_rangefield only documented the /22 runtime block, and the UI exposed an option the provider seemingly didn't (hashicorp/terraform-provider-google#19501).In fact the Apigee Instance API's
ipRangealready accepts a comma-separated list of /22 and/or /28 blocks ("a.b.c.d/22,e.f.g.h/28"), and the provider'sip_rangeis a plain string that passes the value straight through. So the value worked — the gap was documentation and the lack of an example showing it.Changes
ip_rangefield description to document the /28 support range and the comma-separated"/22,/28"input format (matching the API docs).apigee_instance_ip_range_with_support_range_test: reserves a /20 and creates an instance with both an explicit /22 runtime range and an explicit /28 support range, proving the combined format works end to end.No schema/behavior change —
ip_rangealready forwarded the value; this makes the capability discoverable and regression-tested.Test evidence
Fixes hashicorp/terraform-provider-google#19501