Skip to content

feat(agentregistry): Add Agent Registry Agent resource#17969

Draft
JamesDuncanNz wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
JamesDuncanNz:feat/agentregistry-agent
Draft

feat(agentregistry): Add Agent Registry Agent resource#17969
JamesDuncanNz wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
JamesDuncanNz:feat/agentregistry-agent

Conversation

@JamesDuncanNz

Copy link
Copy Markdown
Contributor

This PR introduces the google_agent_registry_agent resource to the google-beta provider. This resource enables users to manage registered Agents within the Google Cloud Agent Registry.

Key Features:

  • Full CRUD support for google_agent_registry_agent.
  • Support for configuring display_name and description.
  • Support for the interfaces block to define connection details (destination URL and protocol bindings: HTTP_JSON, JSONRPC, GRPC).
  • Support for the agent_spec block to define the agent specification (type and JSON content).

Acceptance Tests Status:

The acceptance tests have been run successfully locally against the duncanjames-agw-tf project.

=== RUN   TestAccAgentRegistryAgent_agentRegistryAgentBasicExample
=== PAUSE TestAccAgentRegistryAgent_agentRegistryAgentBasicExample
=== CONT  TestAccAgentRegistryAgent_agentRegistryAgentBasicExample
--- PASS: TestAccAgentRegistryAgent_agentRegistryAgentBasicExample (32.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/agentregistry	32.477s

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

agentregistry: added `google_agent_registry_agent` resource

@modular-magician

modular-magician commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f3c0ffc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 262 insertions(+)
google-beta provider View Diff 13 files changed, 1589 insertions(+)
terraform-google-conversion View Diff 1 file changed, 232 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_registry_agent (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_registry_agent" "primary" {
  agent_spec {
    content = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_registry_agent

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6573 5882 685 6
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentRegistryAgent_agentRegistryAgentBasicExample
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAgentRegistryAgent_agentRegistryAgentBasicExample
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@JamesDuncanNz VCR tests complete for f3c0ffc!

This adds a new example 'agent_registry_agent_full' which uses
'A2A_AGENT_CARD' type and provides a mock JSON content. This covers
the 'agent_spec.content' field in acceptance tests, resolving the
missing test coverage warning.

TAG=agy
CONV=dd28f7a3-e9fb-4833-81a4-72ce577e3c5f
@modular-magician

modular-magician commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5290c5a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 306 insertions(+)
google-beta provider View Diff 13 files changed, 1706 insertions(+)
terraform-google-conversion View Diff 1 file changed, 232 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_registry_agent

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6579 5887 685 7
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentRegistryAgent_agentRegistryAgentFullExample
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFolderIamPolicy_basic
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants