Skip to content

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"#18038

Closed
guvenenb wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
guvenenb:revert-17944-online_evals
Closed

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"#18038
guvenenb wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
guvenenb:revert-17944-online_evals

Conversation

@guvenenb

@guvenenb guvenenb commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Release Note

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"

This reverts the changes introduced in #17944.

The `google_vertex_ai_online_evaluator` resource has been reverted.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 23, 2026
@github-actions github-actions Bot requested a review from rileykarson June 23, 2026 09:25
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

if [ "${{ github.event_name }}" == "pull_request" ]; then
# For PRs, get only changed files
yamlfiles=$(git diff --name-only origin/${GITHUB_BASE_REF} -- mmv1/products)
yamlfiles=$(git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} -- mmv1/products)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this got changed but shouldn't be included? It wasn't in the first PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was actually required to pass the CI. It was giving some error before adding this line, because I deleted the YAML file and the YAML linter tried to lint the deleted file and failed.

@rileykarson

Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer slevenick

@github-actions github-actions Bot requested review from slevenick and removed request for rileykarson June 23, 2026 15:42
@guvenenb guvenenb closed this Jun 24, 2026
@guvenenb guvenenb deleted the revert-17944-online_evals branch June 24, 2026 15:06
@guvenenb guvenenb restored the revert-17944-online_evals branch June 25, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants