Skip to content

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource" #18084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SirGitsalot merged 2 commits into from
Jun 29, 2026
Merged

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource" #18084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f35b39
Revert "feat(vertexai): add google_vertex_ai_online_evaluator resourc…
guvenenb Jun 23, 2026
477fcd1
ci: exclude deleted files from yaml linting to fix revert PR
guvenenb Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit-test-mmv1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
cd repo
if [ "${{ github.event_name }}" == "pull_request" ]; then
# For PRs, get only changed files
yamlfiles=$(git diff --name-only origin/${GITHUB_BASE_REF} -- mmv1/products)
yamlfiles=$(git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} -- mmv1/products)

@guvenenb guvenenb Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this change to pass the CI. Otherwise it is giving some error b because the YAML linter tries to lint the deleted file and fails

if [ ! -z "$yamlfiles" ]; then
echo "yamlfiles=${yamlfiles//$'\n'/ }" >> $GITHUB_OUTPUT
fi
Expand Down
200 changes: 0 additions & 200 deletions mmv1/products/vertexai/OnlineEvaluator.yaml
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions mmv1/templates/terraform/samples/services/vertexai/vertex_ai_online_evaluator_basic.tf.tmpl
View file
Open in desktop

This file was deleted.

Loading
Loading