POC: Configurable Event Definition Visibility Enforcement for Alerts#26476
Draft
kingzacko1 wants to merge 2 commits into
Draft
POC: Configurable Event Definition Visibility Enforcement for Alerts#26476kingzacko1 wants to merge 2 commits into
kingzacko1 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Enforce Event Definitions permissionsto Events Configuration to optionally enforce event definition visibility when performing alerts searches.Additional query logic is only added if the config option is enabled and the searching user does not have
eventdefinitions:readpermission. Requires usingDBEventDefinitionService.findPermittedIdswhich does introduce O(N) iteration over the entireevent_definitionscollection, as well as a newORquery on the EventsSearch itself./prd Graylog2/graylog-plugin-enterprise#14611
Motivation and Context
proposed solution to Graylog2/graylog-plugin-enterprise#14355
How Has This Been Tested?
minimal validation in a dev environment ensuring sharing of event definitions directly, by team, and by collection is supported. Will need to add IT tests and test thoroughly if we want to move forward with this feature.
Screenshots (if appropriate):
Types of changes
Checklist: