Skip to content

POC: Configurable Event Definition Visibility Enforcement for Alerts#26476

Draft
kingzacko1 wants to merge 2 commits into
masterfrom
implement-event-definition-visibility-enforcement-on-alerts-search
Draft

POC: Configurable Event Definition Visibility Enforcement for Alerts#26476
kingzacko1 wants to merge 2 commits into
masterfrom
implement-event-definition-visibility-enforcement-on-alerts-search

Conversation

@kingzacko1

@kingzacko1 kingzacko1 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Adds Enforce Event Definitions permissions to Events Configuration to optionally enforce event definition visibility when performing alerts searches.

Additional query logic is only added if the config option is enabled and the searching user does not have eventdefinitions:read permission. Requires using DBEventDefinitionService.findPermittedIds which does introduce O(N) iteration over the entire event_definitions collection, as well as a new OR query on the EventsSearch itself.
/prd Graylog2/graylog-plugin-enterprise#14611

Motivation and Context

proposed solution to Graylog2/graylog-plugin-enterprise#14355

How Has This Been Tested?

minimal validation in a dev environment ensuring sharing of event definitions directly, by team, and by collection is supported. Will need to add IT tests and test thoroughly if we want to move forward with this feature.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kingzacko1 kingzacko1 marked this pull request as draft June 25, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant