Skip to content

Add Edit input button to the Input Diagnosis page#26491

Open
ousmaneo wants to merge 6 commits into
masterfrom
add-edit-input-button-to-diagnosis-page
Open

Add Edit input button to the Input Diagnosis page#26491
ousmaneo wants to merge 6 commits into
masterfrom
add-edit-input-button-to-diagnosis-page

Conversation

@ousmaneo

Copy link
Copy Markdown
Contributor

Editing an input was only reachable via the "Edit input" item buried in
each row's More menu on the inputs overview. Clicking an input name opens
the Input Diagnosis page, which had no edit affordance, making a basic
action hard to discover.

Add an "Edit input" button next to the diagnosis tab control that opens
the existing edit modal. The action reuses the existing InputForm modal,
the updateInput mutation, telemetry events, and the same permission gate
(inputs:edit + input_types:create) as the overview row action.

/nocl
fix #25430

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo requested a review from a team June 26, 2026 08:26

@gally47 gally47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but the Input Diagnosis page is not picking up the input updates like Title edit.

@ousmaneo ousmaneo requested a review from gally47 July 1, 2026 12:23

@gally47 gally47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editing an input is hard to discover because the edit action is hidden in the overview row menu

3 participants