Sc 115 add pagination to all tables that do not have it by nbeatty-gpa · Pull Request #873 · GridProtectionAlliance/SystemCenter

nbeatty-gpa · 2026-06-10T16:01:29Z

Adds pagination to tables, especially in "info" tabs

Jira Work Item(s)

SC-115

Copilot

Pull request overview

This PR adds pagination support across multiple SystemCenter UI tables (especially “info”/detail tabs) by wiring table views to paged search endpoints and introducing/using paged APIs on the backend where needed.

Changes:

Add <Paging /> controls to many TSX table views and update sorting/page state handling.
Introduce/extend paged API endpoints for several resources (e.g., security group users, asset group members, asset connections/channels, location images).
Extend Redux/EventChannel slice state to support paged results and update store typing setup.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ValueListGroup/ValueListGroupItem.tsx	Adds paging and server-side sort/page flow for value list items.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/User/UserGroup/GroupUsers.tsx	Switches group user listing to a paged backend endpoint and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/User/UserGroup/ByUserGroup.tsx	Refactors to `GenericController` paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/User/User/ByUser.tsx	Refactors to `GenericController` paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Store/Store.ts	Updates store typing and reducer composition structure.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Store/EventChannelSlice.ts	Adds paged-search thunk/state/selectors for event channels.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/RemoteXDA/RemoteMeterTab.tsx	Adds paging support to remote meter table search results.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/RemoteXDA/RemoteAssetTab.tsx	Adds paging support to remote asset table search results.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/MeterTrendChannel.tsx	Adds paging to trend channel table.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/MeterEventChannel.tsx	Adds paging to event channel table using new paged slice data.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/ChannelScaling/ChannelScalingForm.tsx	Adds client-side paging for scaling wrappers table.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Location/LocationImages.tsx	Adds paging UI for location image lists and updates API call shape.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ExternalDB/ExternalDBTables.tsx	Adds paging UI and paged search for external DB tables listing.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ExternalDB/ExternalDBTableFields.tsx	Moves additional-field table to paged backend query and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Customer/CustomerMeter.tsx	Switches customer meter listing to paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Customer/CustomerAsset.tsx	Switches customer asset listing to paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/CommonComponents/ExternalDBUpdate.tsx	Updates UI message strings during external DB updates.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ChannelGroup/ChannelGroupItem.tsx	Adds paging and server-side sort/page flow for channel group details.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/MeterAssetGroup.tsx	Adds paging UI and paged backend calls for meters in an asset group.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/ByAssetGroup.tsx	Adds paging UI and paged searching for asset group listing.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/AssetGroupAssetGroup.tsx	Adds paging UI and paged backend calls for subgroups in an asset group.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/AssetAssetGroup.tsx	Adds paging UI and paged backend calls for assets in an asset group.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetMeter.tsx	Adds paging UI and paged backend calls for meters tied to an asset.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetLocation.tsx	Adds paging UI and paged backend calls for locations tied to an asset.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetConnection.tsx	Adds paging UI and paged backend calls for asset connections.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetChannel.tsx	Adds paging UI and paged backend calls for connected channels.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AdditionalFields/ByAdditionalField.tsx	Uses paged status/results and adds paging-aware sorting.
Source/Applications/SystemCenter/Model/Security/SecurityGroup.cs	Adds paged users endpoint for security groups.
Source/Applications/SystemCenter/Controllers/OpenXDA/OpenXDALocationController.cs	Adds paged location images endpoint and paging helper.
Source/Applications/SystemCenter/Controllers/OpenXDA/Assets/OpenXDAAssetController.cs	Adds paged endpoints for asset locations/meters/connections/channels.
Source/Applications/SystemCenter/Controllers/OpenXDA/AssetGroups/OpenXDAAssetGroupsController.cs	Adds paged endpoints for asset group members and subgroups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    React.useEffect(() => {
-        if (status == 'uninitiated' || status == 'changed' || parentID != props.Record.ID)
-            dispatch(ValueListSlice.Fetch(props.Record.ID));
+        if (status == 'uninitiated' || status == 'changed')
+            dispatch(ValueListSlice.PagedSearch({ filter: [], sortField: 'SortOrder', ascending: true, page: 0 }));
    }, [status, parentID, props.Record.ID]);


    React.useEffect(() => {
        let handle = getAssetConnections();
        return () => { if (handle != null || handle.abort != null) handle.abort();}
-    }, [props.ID, trigger])
+    }, [props.ID, trigger, page, sortKey, ascending])


+    const getData = React.useCallback(() => {
+        dispatch(CustomerAssetSlice.PagedSearch({ filter: [], sortField, ascending, page }))
+        }, [sortField, ascending, page, CustomerAssetSlice.PagedSearch])


+                            HAVING AssetAssetGroup.AssetGroupID = {{0}}
+                            ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")}
+                            ";


+                        WHERE
+	                        ParentID = {{0}} OR ChildID = {{0}}
+                        ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")}
+                    ", assetID);


+                if (postData.Ascending)
+                    records = records.OrderBy(record => record.GetType().GetProperty(postData.OrderBy).GetValue(record));
+                else
+                    records = records.OrderByDescending(record => record.GetType().GetProperty(postData.OrderBy).GetValue(record));


+                        HAVING MeterAssetGroup.AssetGroupID = {{0}}
+                        ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")}
+                ";


nbeatty-gpa requested a review from elwills June 10, 2026 19:59

nbeatty-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch 3 times, most recently from 9b18228 to de09c01 Compare June 15, 2026 14:44

elwills requested a review from Copilot June 18, 2026 19:39

Copilot started reviewing on behalf of elwills June 18, 2026 19:39 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

nbeatty-gpa added 23 commits June 19, 2026 11:18

paginate substation images

079849b

reset to first page on sort

f9cf267

reset to first page on sort

ec78cb2

reset to first page on sort

3a7948f

reset to first page on sort

205ceaf

reset to first page on sort

40f2bf8

fix styling for paging

7d35794

paginate value list group item

ef46020

page asset ConnectedChannels endpoint

7de72bc

page Asset Channels table

f701623

paginate tables tab of external db

c83fb4b

Fix error filtering users by additional fields

d63dd9e

Refactor byUser page from slices to local state with Generic Controller

83788a9

clean up byUser

0ff1748

move ByUserGroup from GenericSlice to GenericController

441f9c0

paginate GroupUsers

a613530

paginate ExternalDBTableFields

e98b73f

paginate byAssetGroup

4ac602c

paginate assetGroupSubGroups

6041cf0

paginate assetGroupsAssets

176b489

paginate assetGroupMeters

f3d5679

paginate assetSubstations

6a91625

paginate assetMeters

45e7e16

nbeatty-gpa added 22 commits June 19, 2026 11:18

paginate assetConnections

aae26db

paginate customerMeter

9cf5285

paginate customerAsset

97c916d

paginate MeterTrendChannel

f8675e3

remove accidental comment

a717ead

paginate meterChannelScaling table

bccb9a5

paginate meterEventChannels

6e5ad64

Paginate remoteXDA assets

6cb8140

Paginate remoteXDA meters

bd3a04a

simplify settings sort

3fa81df

clean up user and userGroup

012629d

fix generic controller typing

2b39d13

fix dependency array

48e7670

use stricter typing in EventChannelSlice

339b3df

changes to store typing

65898dd

cleanup import

c630416

fix typing

b3932c2

refresh on changed

d8975c4

fix broken Additional Field selector in ExternalDBTable

5770c54

fix decimal page

85069e6

fix grammar mistakes in ExternalDBUpdate

cb87bf1

do not error out completely on uncompleted search

3d7977f

nbeatty-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch from 73a24e6 to 3d7977f Compare June 19, 2026 17:14

nbeatty-gpa added 7 commits June 19, 2026 13:16

fix utf-A typo

c09f9b9

remove companySlice from merged store

c048ff9

abort correct handle

00021a8

return empty PagedResults if no images found for substation

6ec222e

include 'loading' status during paged search

9e91383

filter customer assets on customer ID

6fac9b9

add filters to value list

9418b07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sc 115 add pagination to all tables that do not have it#873

Sc 115 add pagination to all tables that do not have it#873
nbeatty-gpa wants to merge 52 commits into
masterfrom
SC-115-Add-pagination-to-all-tables-that-do-not-have-it

nbeatty-gpa commented Jun 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nbeatty-gpa commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nbeatty-gpa commented Jun 10, 2026 •

edited

Loading