fix: correct Firebase Storage ref and public URL construction in uploadImage#263
Draft
Copilot wants to merge 5 commits into
Draft
fix: correct Firebase Storage ref and public URL construction in uploadImage#263Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Copilot
AI
changed the title
[WIP] Add file extension for uploaded media files
Normalize uploaded media filenames to a single detected extension
May 29, 2026
Copilot
AI
changed the title
Normalize uploaded media filenames to a single detected extension
Fix media storage paths to always end with the correct extension
May 29, 2026
Copilot
AI
changed the title
Fix media storage paths to always end with the correct extension
fix: return actual public URL from PDF export instead of storage path
May 29, 2026
Copilot
AI
changed the title
fix: return actual public URL from PDF export instead of storage path
fix: correct Firebase Storage ref and public URL construction in uploadImage
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uploadImagereceivedimageFolderas a full public URL (e.g.https://storage.googleapis.com/bucket/events/evt-1/) fromfilesPath.imageFolder, then passed it directly to Firebase'sref(storage, url). Firebase only recognisesgs://andfirebasestorage.googleapis.comURLs — everything else is treated as a raw path string, causing the ref to point to a garbled location and the returned URL to be wrong.Changes
src/utils/images/uploadImage.tsimageFolderbefore creating theref(), handling bothstorage.googleapis.com/BUCKET/andBUCKET.storage.googleapis.com/formatsoutputRef.fullPath, matching thehttps://BUCKET.storage.googleapis.com/PATHformat used by the server-sideuploadBufferToStorage