Skip to content

fix: accumulate serial chunks in _read_metadata to prevent calibration data loss #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentinkauf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: accumulate serial chunks in _read_metadata to prevent calibration data loss #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions src/ppk2_api/ppk2_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,26 +167,18 @@ def _convert_source_voltage(self, mV: int) -> Tuple[int, int]:

def _read_metadata(self) -> str:
"""Read metadata"""
# try to get metadata from device
for _ in range(0, 5):
accumulated = ""
for _ in range(0, 10):
read = self.ser.read(self.ser.in_waiting)
time.sleep(0.1)

if not read:
continue # No data, try again

# Try decoding the data
continue
try:
metadata = read.decode("utf-8")
accumulated += read.decode("utf-8")
except UnicodeDecodeError:
# If decoding fails, try again in next iteration
continue

# Check if the metadata is valid (i.e., contains "END")
if "END" in metadata:
return metadata

# If we exit the loop, it means we couldn't get valid metadata
if "END" in accumulated:
return accumulated
raise ValueError("Could not retrieve valid metadata from the device.")

def _parse_metadata(self, metadata: str) -> None:
Expand Down