Fix Plex sink username filtering#1799
Merged
Merged
Conversation
Contributor
WalkthroughThe Plex Sink now documents exact ChangesPlex Sink username matching
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Account.titleRoot cause
The optional username form field preserves an empty value as an empty string. The sink treated that as an active filter, causing every Plex webhook to be rejected without explaining why. The documentation also instructed users to enter their Plex full name even though current payloads expose the matching value through
Account.title, typically the Plex username.Verification
rustfmt --edition 2024 --check crates/services/integration/src/sink/plex.rsyarn turbo lint --filter=@ryot/frontend --filter=@ryot/docsyarn turbo build --filter=@ryot/frontendyarn turbo build --filter=@ryot/docsFixes #1798
Summary by CodeRabbit
Bug Fixes
Account.titlevalue from Plex webhook payloads.Documentation
UI Improvements