Small bug fix in FitConverter#401
Merged
Merged
Conversation
Old function was extracting only the sum from "reaction::sum::amp", when it should have been extracting "sum::amp" instead. Aside from this, a comment was modified and a formatter was used on files I forgot to format before committing.
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_csv_converter.log |
Contributor
|
Hi @kevScheuer Thank you so much for fixing this this fast. I tested and it works now for the sdme type fit. |
lihaoahil
approved these changes
Jul 8, 2026
lihaoahil
left a comment
lihaoahil
left a comment
Contributor
There was a problem hiding this comment.
tested, works with the sdme fit now.
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_csv_converter.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised in @lihaoahil 's comment from the original pull request. The issue was because of a mistake in the
uniqueSumAmpNamesfunction, where only thesuminreaction::sum::ampwas being extracted, instead of the intendedsum::amp.I ran
I've attached the debug output and csv file below for reference.
output.txt
test.csv
Aside from this, small formatting changes were made, and an outdated comment was edited.