Skip to content

prepare deprecation of simple and alternative#507

Open
jverzani wants to merge 3 commits into
JuliaMath:masterfrom
jverzani:fzero
Open

prepare deprecation of simple and alternative#507
jverzani wants to merge 3 commits into
JuliaMath:masterfrom
jverzani:fzero

Conversation

@jverzani
Copy link
Copy Markdown
Member

@jverzani jverzani commented Apr 22, 2026

This PR does:

  • streamlines fzero
  • separates out code and tests for alternative_interfaces and simple. (some goes into find_zeros)
  • prepares deprecation warnings for functions in alternative_interfaces and simple (but doesn't uncomment them yet)
  • add modab code to simple, as it was contributed and might be of independent interest

The goal is to deprecate the two files, both could be elsewhere, especially alternative interfaces which has had comments about it being legacy for years now.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 62.65060% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.96%. Comparing base (a45a34f) to head (aaac10e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/deprecated/simple.jl 14.49% 59 Missing ⚠️
src/find_zeros.jl 96.55% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   86.93%   82.96%   -3.98%     
==========================================
  Files          41       41              
  Lines        2565     2607      +42     
==========================================
- Hits         2230     2163      -67     
- Misses        335      444     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant