fix(code-review): add model diagnostics#3990
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit ( Resolved Issues
Other Observations (not in diff — carried forward, still open)These were noted in earlier reviews and are not blocking, but remain unaddressed:
Files Reviewed (24 files)
Reviewed by claude-4.6-sonnet-20260217 · 3,649,342 tokens Review guidance: REVIEW.md from base branch |
| "dependencies": { | ||
| "@kilocode/sdk": "7.3.21" | ||
| "@kilocode/sdk": "7.3.21", | ||
| "fuzzysort": "3.1.0" |
There was a problem hiding this comment.
@eshurakov how do you feel about adding a new dependency? When a model is not found, I do a fuzzy search on the available runtime (CLI) models against the one set in web and return just a few.
…lid model patterns
…-list # Conflicts: # services/cloud-agent-next/src/callbacks/types.ts # services/cloud-agent-next/src/session/message-settlement-outbox.ts # services/cloud-agent-next/src/session/wrapper-supervisor.ts # services/cloud-agent-next/src/websocket/ingest.ts # services/cloud-agent-next/test/unit/wrapper/reconnection.test.ts # services/cloud-agent-next/wrapper/src/connection.ts
Summary
isModelNotFoundMessageregex to also matchunknown modelandinvalid modelpatterns, keeping it in sync withclassifyAssistantFailureMessageinsafe-failure-projection.tsso those error variants no longer skip diagnostics.Verification
Manual staging checks:
Visual Changes
N/A
Reviewer Notes
isModelNotFoundMessagenow mirrors the regex pattern inclassifyAssistantFailureMessage:/\b(model (?:was )?not found|unknown model|invalid model)\b/i.Built for alex-alecu by Kilo