Fix compilation error when using Algorithm::setPushConstants(const std::vector<T> &)#466
Merged
axsaucedo merged 4 commits intoJul 16, 2026
Merged
Conversation
Signed-off-by: Mitja Puzigaća <mitjap@gmail.com>
Signed-off-by: Mitja Puzigaća <mitjap@gmail.com>
mitjap
force-pushed
the
fix-push-constants-const
branch
from
July 16, 2026 15:34
7bbead5 to
090cc26
Compare
Signed-off-by: Mitja Puzigaća <mitjap@gmail.com>
mitjap
force-pushed
the
fix-push-constants-const
branch
from
July 16, 2026 16:46
6295bd6 to
1163efe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is templated and is never instantiated in
komputeproject so the compilation error was not detected.When calling
Algorithm::setPushConstants(const std::vector<T> &), this function then callsAlgorithm::setPushConstants(void* data, uint32_t size, uint32_t memorySize)which acceptsnon-constpointer.This PR adds a test that instantiates this function and validates the results and also fixes the incorrect function signature.