GrblHAL compatibility#116
Open
bullestock wants to merge 2 commits into
Open
Conversation
colintrachte
added a commit
to colintrachte/lw.comm-server
that referenced
this pull request
Apr 1, 2026
colintrachte
added a commit
to colintrachte/lw.comm-server
that referenced
this pull request
Jun 20, 2026
…atibility GrblHAL version detection (PR LaserWeb#116): - Fix Grbl version parsing in Telnet and ESP paths to use dynamic space-finding instead of hardcoded substr(5,4), matching the already- fixed USB path. GrblHAL sends "GrblHAL 1.1" where the version starts at a different offset than plain "Grbl 1.1h". GRBL 0.x framing format (PR LaserWeb#118): - Strip {count/total} framing prefix that GRBL 0.8 prepends to responses before further parsing, preventing those lines from being mishandled. GRBL 0.x feature flags (PR LaserWeb#118): - firmwareFeatures.get() now accepts an optional version parameter. GRBL 0.x versions return feedOverride:false and spindleOverride:false since those real-time override commands did not exist in that era. - Pass fVersion through the getFeatureList socket handler. Node 18 / Docker (PR LaserWeb#117): - Replace end-of-life resin/raspberrypi3-node:10 base image with node:18. - Tighten package.json engines field to >=18 (minimum with long-term support). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grblHAL prints "grblHAL 1.1" by default, whereas standard grbl prints "grbl 1.1".
This PR adds compatibility with grblHAL by locating the space before parsing the version number.