reorganize headers#6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried clang-formatting all the code and suddenly got a wall of errors because the includes were sorted, so I figured it should be solved once for all
Generally headers/includes should be:
<cstdint>, then you should just include that instead of some otherFoo.hthat happens to include<cstdint>Following these will make it less likely that when you change some header and something seemingly completed unrelated start breaking up, and builds will be faster because when you change some header there will be less stuff that needs recompiled
I did this manually with clangd's unused-include diagnostic and tested build works (and works when ported to my mod)
Another issue that exists is the include paths are kind of messy right now, for example SexyAppFramework headers can be included either like
"Foo.h"or"SexyAppFramework/Foo.h"(since the include paths for sub-projects needs to be PUBLIC they just leak everywhere), and there are a bunch of "../../" includes. Ideally we only exposesrcin include paths and everyone should include like<Lawn/XXX.h>or<SexyAppFramework/XXX.h>